-
Notifications
You must be signed in to change notification settings - Fork 8.4k
fix: prompt component display names and code of starter templates #11466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…e starter projects
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
WalkthroughThis PR renames the "Prompt" component to "Prompt Template" across 19 starter project JSON files by updating Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (6 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (41.71%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11466 +/- ##
=======================================
Coverage 34.89% 34.90%
=======================================
Files 1420 1420
Lines 68217 68217
Branches 9984 9984
=======================================
+ Hits 23804 23808 +4
+ Misses 43179 43174 -5
- Partials 1234 1235 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
For posterity: Checked with Viktor to verify if there are any templates not covered that need this change as well. Changes looks good otherwise. |
dkaushik94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jira LE-159
This pull request updates the templates starter project to consistently use the name "Prompt Template" instead of "Prompt" for relevant components. It also updates the underlying code for the
PromptComponentto reflect this naming and removes the unused "mode" input field, streamlining the configuration and improving clarity.Component naming and configuration updates:
display_nameandnamefrom "Prompt" to "Prompt Template" for prompt-related components in the starter project configuration. [1] [2] [3] [4]Component code and field updates:
PromptComponentto use "Prompt Template" as itsdisplay_nameandname, and removed the "mode" input field, relying instead on theuse_double_bracketsboolean for template syntax selection.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.