Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conditional-router): rename 'matches regex' to 'regex' #5410

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def __init__(self, *args, **kwargs):
DropdownInput(
name="operator",
display_name="Operator",
options=["equals", "not equals", "contains", "starts with", "ends with", "matches regex"],
options=["equals", "not equals", "contains", "starts with", "ends with", "regex"],
info="The operator to apply for comparing the texts.",
value="equals",
real_time_refresh=True,
Expand Down Expand Up @@ -72,7 +72,7 @@ def _pre_run_setup(self):
self.__iteration_updated = False

def evaluate_condition(self, input_text: str, match_text: str, operator: str, *, case_sensitive: bool) -> bool:
if not case_sensitive and operator != "matches regex":
if not case_sensitive and operator != "regex":
input_text = input_text.lower()
match_text = match_text.lower()

Expand All @@ -86,7 +86,7 @@ def evaluate_condition(self, input_text: str, match_text: str, operator: str, *,
return input_text.startswith(match_text)
if operator == "ends with":
return input_text.endswith(match_text)
if operator == "matches regex":
if operator == "regex":
try:
return bool(re.match(match_text, input_text))
except re.error:
Expand Down Expand Up @@ -125,7 +125,7 @@ def false_response(self) -> Message:

def update_build_config(self, build_config: dict, field_value: str, field_name: str | None = None) -> dict:
if field_name == "operator":
if field_value == "matches regex":
if field_value == "regex":
if "case_sensitive" in build_config:
del build_config["case_sensitive"]
# Ensure case_sensitive is present for all other operators
Expand Down
Loading