feature: update flowToolbar under feature flag #5895
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the Columns2 icon to the nodeIconsLucide object in the styleUtils.ts file. This icon was missing previously and has now been incorporated. Ref: #issue-number
Added CSS styles for deploy dropdown items in the applies.css file. The styles include padding, hover effects, font size, and rounded corners. This improves the visual appearance and interactivity of the deploy dropdown items.
- Add ENABLE_PUBLISH feature flag to constants.ts - Add styles for deploy dropdown items - Add Columns2 icon to nodeIconsLucide - Update strokeWidth of Play icon based on ENABLE_PUBLISH flag - Update button label to use PLAYGROUND_BUTTON_NAME constant
This commit adds the FlowToolbarOptions component to the flowToolbarComponent. The component includes a PlaygroundButton and a DeployDropdown. The PlaygroundButton allows users to interact with the flow's input and output, while the DeployDropdown provides options for deploying the flow. This addition enhances the functionality of the flowToolbarComponent.
…nt and ENABLE_PUBLISH feature flag
dosubot
bot
added
size:L
…ases where there is no IO
simonfraserduncan
suggested changes
Jan 24, 2025
src/frontend/src/components/core/flowToolbarComponent/components/deploy-dropdown.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/components/core/flowToolbarComponent/components/deploy-dropdown.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/components/core/flowToolbarComponent/components/deploy-dropdown.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/components/core/flowToolbarComponent/components/deploy-dropdown.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ENABLE_PUBLISH feature flag to the constants.ts file and includes the FlowToolbarOptions component in the flowToolbarComponent. The ENABLE_PUBLISH feature flag allows for conditional rendering of certain elements based on whether publishing is enabled. The FlowToolbarOptions component enhances the functionality of the flowToolbarComponent by adding a PlaygroundButton and a DeployDropdown. The PlaygroundButton allows users to interact with the flow's input and output, while the DeployDropdown provides options for deploying the flow.