Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add LangChain vector store adapter for CrateDB #6011

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amotl
Copy link

@amotl amotl commented Jan 29, 2025

Hi there,

thanks a stack for conceiving Langflow. Hereby, we are adding another vector store adapter for CrateDB, which is effectively the same like the one for PostgreSQL/PGVector, because CrateDB is compatible with PostgreSQL.

With kind regards,
Andreas.

@amotl amotl marked this pull request as ready for review January 29, 2025 23:11
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jan 29, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 5, 2025
@amotl amotl changed the title Add LangChain vector store adapter for CrateDB feat: Add LangChain vector store adapter for CrateDB Feb 5, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 5, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 5, 2025
@ogabrielluiz
Copy link
Contributor

Hey @amotl

I was not able to run Langflow because the icon you provided is not valid. Could you take a look at it, please?

Copy link
Author

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ogabrielluiz, thanks for your reply. I hope we can resolve the icon/logo issue soon. I've provided a few bits of information below, within a PR discussion thread attached to the cratedb.svg file.

src/frontend/src/icons/CrateDB/cratedb.svg Outdated Show resolved Hide resolved
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 5, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 5, 2025
.github/workflows/codeflash.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 7, 2025
Comment on lines 7 to 9
height="600"
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing this:

Suggested change
height="600"
>
height="600"
{...props}
>

Copy link
Author

@amotl amotl Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I've just amended the patch by adding the missing {...props}.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ogabrielluiz. I think this patch would be ready to be integrated now. Apologies for the woes around getting the logo right. May we humbly ask you to have a look at this again?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Gabriel,

do you need anything else from us to complete this patch?

With kind regards,
Andreas.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 7, 2025
@amotl amotl requested a review from ogabrielluiz February 7, 2025 16:51
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 7, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 11, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 12, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 12, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 12, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 12, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants