Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds metadata and batch_index to batch_run #6318

Merged
merged 10 commits into from
Feb 14, 2025

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request includes significant updates to the BatchRunComponent in the langflow package, adding new features and enhancing existing functionalities. It also includes updates to the related unit tests to ensure comprehensive test coverage.

Enhancements to BatchRunComponent:

  • Added new input types BoolInput and MessageTextInput to BatchRunComponent and marked several inputs as required. (src/backend/base/langflow/components/helpers/batch_run.py) [1] [2] [3] [4]
  • Updated the run_batch method to include metadata in the output DataFrame and handle errors gracefully. (src/backend/base/langflow/components/helpers/batch_run.py) [1] [2] [3]

Unit Test Updates:

  • Added new test cases to cover scenarios with and without metadata, and to handle various error conditions. (src/backend/tests/unit/components/helpers/test_batch_run_component.py) [1] [2] [3]
  • Minor formatting adjustments to ensure consistency and readability across test files. (src/backend/tests/unit/api/v1/test_api_schemas.py, src/backend/tests/unit/mock_language_model.py, src/backend/tests/unit/serialization/test_serialization.py, src/backend/tests/unit/test_schema.py) [1] [2] [3] [4]

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 12, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 12, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 12, 2025
@anovazzi1 anovazzi1 changed the title feat: adds metadata and batch_index to batch_run and fixes out of order data output issues feat: adds metadata and batch_index to batch_run Feb 13, 2025
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 13, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 13, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 13, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 14, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 14, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 14, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 14, 2025
@edwinjosechittilappilly edwinjosechittilappilly added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit a1967bc Feb 14, 2025
33 checks passed
@edwinjosechittilappilly edwinjosechittilappilly deleted the fix_batch_run branch February 14, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants