Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added save button to table component to improve consistency #6663

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

lucaseduoli
Copy link
Collaborator

This pull request includes significant enhancements to the TableNodeComponent and the TableModal components to improve the handling of temporary values and modal state management. The most important changes include the introduction of temporary state management for table values, the addition of modal open state handling, and the implementation of save and cancel functionality in the modal.

Enhancements to TableNodeComponent:

  • Introduced tempValue state to manage temporary table values and updated relevant functions to use tempValue instead of value. [1] [2] [3]
  • Added isModalOpen state to manage the modal's open state.
  • Implemented handleSave and handleCancel functions to handle save and cancel actions in the modal.

Enhancements to TableModal:

  • Extended TableModalProps to include open, setOpen, onSave, and onCancel properties.
  • Updated TableModal component to handle the new open, setOpen, onSave, and onCancel properties, including triggering the appropriate callbacks. [1] [2] [3]

These changes collectively improve the user experience by providing better control over table data modifications and modal interactions.

@lucaseduoli lucaseduoli self-assigned this Feb 17, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Feb 17, 2025
@github-actions github-actions bot added the bug Something isn't working label Feb 17, 2025
…yDown functions to improve code readability and maintainability
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 18, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 18, 2025
@lucaseduoli lucaseduoli added lgtm This PR has been approved by a maintainer and removed lgtm This PR has been approved by a maintainer labels Feb 18, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 18, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 18, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 18, 2025
@Cristhianzl Cristhianzl added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit 70bb897 Feb 18, 2025
22 checks passed
@Cristhianzl Cristhianzl deleted the fix/save_check_modals branch February 18, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants