-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Simplify loop stopping condition to prevent off-by-one errors #6696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… should stop based on current index and data length 📝 (LoopTemplate.json): Update output_types to be arrays for consistency and readability in LoopTemplate JSON file
…p should stop or continue based on current index and data length
CodSpeed Performance ReportMerging #6696 will not alter performanceComparing Summary
|
ogabrielluiz
approved these changes
Feb 19, 2025
…ect number of occurrences of "modified_value" in the output
…angflow into cz/loop-interation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
LoopTemplate.json
file and a minor update to theevaluate_stop_loop
method in theloop.py
file. The changes primarily focus on formatting and improving the logic for evaluating when to stop the loop.Logic Improvement:
evaluate_stop_loop
method inloop.py
to ensure the loop correctly evaluates when to stop by usingmax(data_length - 1, 0)
instead of justdata_length
. This prevents potential off-by-one errors.