fix: Simplify loop stopping condition to prevent off-by-one errors #6696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… should stop based on current index and data length 📝 (LoopTemplate.json): Update output_types to be arrays for consistency and readability in LoopTemplate JSON file
…p should stop or continue based on current index and data length
dosubot
bot
added
size:L
github-actions
bot
added
bug
github-actions
bot
added
bug
CodSpeed Performance ReportMerging #6696 will not alter performanceComparing Summary
|
github-actions
bot
added
bug
ogabrielluiz
approved these changes
Feb 19, 2025
Cristhianzl
added
lgtm
github-actions
bot
added
bug
dosubot
bot
added
size:XS
github-actions
bot
added
bug
…ect number of occurrences of "modified_value" in the output
…angflow into cz/loop-interation
github-actions
bot
added
bug
github-actions
bot
added
bug
Yukiyukiyeah
pushed a commit
that referenced
this pull request
Mar 31, 2025
…6696) * 🐛 (loop.py): Fix logic in LoopComponent to correctly evaluate if loop should stop based on current index and data length 📝 (LoopTemplate.json): Update output_types to be arrays for consistency and readability in LoopTemplate JSON file * 🐛 (loop.py): fix logic in stop condition to correctly evaluate if loop should stop or continue based on current index and data length * [autofix.ci] apply automated fixes * ✅ (loop-component.spec.ts): update test expectation to match the correct number of occurrences of "modified_value" in the output --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
LoopTemplate.jsonfile and a minor update to theevaluate_stop_loopmethod in theloop.pyfile. The changes primarily focus on formatting and improving the logic for evaluating when to stop the loop.Logic Improvement:
evaluate_stop_loopmethod inloop.pyto ensure the loop correctly evaluates when to stop by usingmax(data_length - 1, 0)instead of justdata_length. This prevents potential off-by-one errors.