Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Creation of collections in dev Astra DB #6698

Merged
merged 9 commits into from
Feb 18, 2025
Merged

fix: Creation of collections in dev Astra DB #6698

merged 9 commits into from
Feb 18, 2025

Conversation

erichare
Copy link
Collaborator

This pull requests ensures that, when creating a collection, the selected environment is properly passed to the astra db component

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Feb 18, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 18, 2025
Cristhianzl
Cristhianzl approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 18, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 18, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 18, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 18, 2025
@erichare erichare disabled auto-merge February 18, 2025 20:05
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 18, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 18, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #6698 will not alter performance

Comparing fix-dev-env-collection (9e19604) with main (b8346a0)

Summary

✅ 14 untouched benchmarks

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 18, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 18, 2025
@erichare erichare enabled auto-merge February 18, 2025 20:17
@erichare erichare added this pull request to the merge queue Feb 18, 2025
@erichare erichare removed this pull request from the merge queue due to a manual request Feb 18, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 18, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 18, 2025
@erichare erichare enabled auto-merge February 18, 2025 20:30
@erichare erichare disabled auto-merge February 18, 2025 20:35
@Cristhianzl Cristhianzl added this pull request to the merge queue Feb 18, 2025
@erichare erichare removed this pull request from the merge queue due to a manual request Feb 18, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 18, 2025
@erichare erichare enabled auto-merge February 18, 2025 20:51
@erichare erichare added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit bc1210a Feb 18, 2025
36 checks passed
@erichare erichare deleted the fix-dev-env-collection branch February 18, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cristhianzl Cristhianzl Cristhianzl approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erichare @Cristhianzl