-
Notifications
You must be signed in to change notification settings - Fork 7k
docs: add env var setup for macOS and Windows GUI #8181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Build successful! ✅ |
Build successful! ✅ |
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe documentation was updated to add detailed instructions for setting environment variables specifically for the Langflow Desktop application on macOS and Windows. The new section explains the differences from terminal-based environment variables and provides step-by-step guidance for both operating systems. Additionally, the installation guide was updated to reference this new section. Changes
Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Build successful! ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
docs/docs/Configuration/environment-variables.md (5)
380-385
: Consider adding an anchor for linkability
The new “Set environment variables for Langflow Desktop” section would benefit from a Docusaurus anchor (e.g.,{#configure-variables-desktop}
) so you can link directly to it from other docs or the TOC.
386-387
: Add anchors to each OS subsection
To improve navigability, consider adding IDs to the macOS and Windows subsection headings, for example:### Set environment variables for Langflow Desktop for macOS {#desktop-macos} ### Set environment variables for Langflow Desktop on Windows {#desktop-windows}This will let users link directly to platform-specific instructions.
Also applies to: 428-429
388-389
: Fix spacing around inline code
There is a missing space before the backtick-wrapped filenames. For example:- variables set in your terminal, such as`.zshrc` or `.bash_profile` + variables set in your terminal, such as `.zshrc` or `.bash_profile`
402-421
: Suggest guidance on reloading updated plist entries
After you’ve created or modified the plist, it’s helpful to show how to reload it without a reboot. For example:launchctl unload ~/Library/LaunchAgents/dev.langflow.env.plist launchctl load ~/Library/LaunchAgents/dev.langflow.env.plistThis ensures changes take effect immediately for GUI apps you’ve already launched.
442-442
: Fix spacing around inline Windows path
Add a space before the backtick for consistency:- value, such as`C:\Users\your_user\.langflow_config` + value, such as `C:\Users\your_user\.langflow_config`
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/docs/Configuration/environment-variables.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-and-deploy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (2)
docs/docs/Configuration/environment-variables.md (2)
379-384
: Add cross-link from Desktop installation guide
Users installing Langflow Desktop may not discover this section. Consider adding a link or note in the Desktop install docs pointing to “Set environment variables for Langflow Desktop.”
379-384
: Use Tabs for OS-specific sections
Rather than multiple subheadings, wrap the macOS, Windows, and PowerShell instructions in a<Tabs>
component for cleaner UX and easier navigation.
🧹 Nitpick comments (2)
docs/docs/Configuration/environment-variables.md (2)
385-425
: Fix spacing and clarify restart requirement
- Insert a space before backticks in “such as
.zshrc
or.bash_profile
”.- After
launchctl load
, note that GUI apps must be restarted (or user logged out/in) to pick up the new variables.@@ 387 - If you're using macOS and want to configure environment variables for the Langflow Desktop version, it's important to know that variables set in your terminal, such as`.zshrc` or `.bash_profile`, are **not automatically available to GUI applications** like Langflow Desktop when launched through Finder or the Dock. + If you're using macOS and want to configure environment variables for the Langflow Desktop version, it's important to know that variables set in your terminal, such as `.zshrc` or `.bash_profile`, are **not automatically available to GUI applications** like Langflow Desktop when launched through Finder or the Dock. @@ After line 425 +:::tip +After loading your plist with `launchctl`, restart Langflow Desktop (or log out and back in) to apply the new environment variables. +:::
427-445
: Unify heading style & mention restart
- Change “Set environment variables for Langflow Desktop on Windows” to match macOS phrasing: e.g. “Set environment variables for Langflow Desktop on Windows.”
- Note that a restart (or sign-out/in) is required for GUI apps to inherit the new variables when set via System Properties.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/docs/Configuration/environment-variables.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-and-deploy
🔇 Additional comments (1)
docs/docs/Configuration/environment-variables.md (1)
446-457
: PowerShell examples are clear
The PowerShell commands correctly cover user and machine scopes and note the need to restart the application. No issues here.
Build successful! ✅ |
…ngflow into docs-gui-env-vars
Build successful! ✅ |
Build successful! ✅ |
Build successful! ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things are a bit inconsistent (ex. random PowerShell tab with no second tab) and should be addressed, but most of my comments are optional. (For @mendonk )
Co-authored-by: April I. Murphy <[email protected]>
Build successful! ✅ |
Co-authored-by: April I. Murphy <[email protected]>
Build successful! ✅ |
Build successful! ✅ |
Adds guidance on how to set env vars for Langflow Desktop on macOS and Windows.
Summary by CodeRabbit