fix: wrong usage of redis lock

[NeatGuyCoding]

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before	After
...	...

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello @NeatGuyCoding, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the reliability and correctness of concurrent operations and data handling within the application. It refines the Redis locking strategy for webhook trigger synchronization, making it more resilient to contention and ensuring proper resource management. Concurrently, it standardizes timestamp generation to use timezone-aware UTC, which is crucial for maintaining data integrity across different environments and preventing potential time-related discrepancies.

Highlights

• Improved Redis Lock Handling: The mechanism for acquiring and releasing Redis locks in webhook_service.py has been significantly improved to ensure proper synchronization and prevent race conditions. Locks are now explicitly acquired with a blocking timeout, and errors are raised if acquisition fails. The release process is also more robust, only releasing the lock if it was successfully acquired by the current process.
• Timezone-Aware Timestamps: Timestamp generation in workflow_service.py has been updated to use timezone-aware UTC datetimes. This change replaces naive datetime usage with datetime.now(timezone.utc), ensuring greater accuracy and consistency for system variable timestamps.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR fixes incorrect usage of Redis locks in the webhook service and updates timestamp generation to use timezone-aware datetime objects. The key changes improve lock acquisition/release handling and ensure proper UTC timestamp generation.

• Replaces naive datetime with timezone-aware UTC datetime
• Fixes Redis lock usage by properly acquiring and releasing locks with appropriate error handling
• Adds blocking timeout and lock state tracking to prevent lock leaks

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
api/services/workflow_service.py	Updates timestamp generation to use timezone-aware UTC datetime
api/services/trigger/webhook_service.py	Fixes Redis lock usage with proper acquisition, state tracking, and safe release

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request correctly fixes a critical issue with Redis lock usage in webhook_service.py, preventing a potential race condition during webhook synchronization. The previous implementation did not acquire the lock, and the new code correctly acquires and releases it. Additionally, the PR fixes a bug in workflow_service.py related to using .timestamp() on a naive datetime object, which could lead to incorrect timestamps. The changes are solid and improve the application's correctness and robustness. I have one suggestion to improve the readability of the lock handling logic.