Skip to content

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Nov 20, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #13738 support seperate memory config

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 💪 enhancement New feature or request labels Nov 20, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the memory management capabilities within the application's workflow nodes, particularly for LLM nodes. It introduces a new concept of 'independent' memory, allowing each node to maintain its own conversational context separate from the main conversation's shared memory. This provides developers with greater flexibility to design complex workflows where memory isolation or transient memory states are required, addressing the need for more sophisticated memory handling in AI applications.

Highlights

  • Separate Memory Configuration: Introduced the ability to configure memory as either 'shared' (conversation-wide) or 'independent' (per-node), providing more granular control over memory management within workflows.
  • Node-Scoped Memory Implementation: Added NodeScopedMemory to handle independent memory, which is persisted as a ConversationVariable and can be optionally cleared after a node's execution.
  • Frontend UI Updates: The workflow editor's memory configuration UI now includes options to select the memory mode (shared/independent) and a toggle to clear independent memory after execution.
  • Memory Abstraction: A new ChatHistoryMemory protocol was introduced to abstract the memory interface, allowing both TokenBufferMemory (shared) and NodeScopedMemory (independent) to be used interchangeably where chat history is needed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable feature by adding support for node-specific, independent memory scopes in workflows. The implementation is solid, with good use of a Protocol for different memory types and corresponding UI changes. I've identified a few areas for improvement, mainly related to performance optimization by avoiding an unnecessary database query and enhancing code clarity and type safety. Overall, this is a great addition.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 20, 2025
@fatelei fatelei force-pushed the issue-13738 branch 2 times, most recently from 83d4797 to 01b9353 Compare November 20, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement of LLM Node Memory Function

1 participant