-
Notifications
You must be signed in to change notification settings - Fork 18.5k
fix: use default values for optional workflow input variables (#28546) #28527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @importcjj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where optional workflow input variables, when not explicitly provided, would default to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly implements the use of default values for optional workflow input variables. A default field has been added to VariableEntity, and the validation logic in _validate_inputs has been updated to use this default value when an optional input is missing. The changes are accompanied by comprehensive tests. My feedback focuses on improving the structure and maintainability of the new tests.
|
When calling workflow API with missing optional fields, they should use configured default values instead of becoming null. The issue was that default values stored as strings (especially for NUMBER type) were not being processed through type validation and conversion logic. Changes: - Add default field to VariableEntity model - Update _validate_inputs to pass default values through validation pipeline - Ensure string number defaults (e.g., "123") are converted to proper types - Add comprehensive test coverage for all supported variable types: * TEXT_INPUT, PARAGRAPH, SELECT - string defaults * NUMBER - int/float/string-formatted number defaults with type conversion * CHECKBOX - boolean defaults * FILE, FILE_LIST - object/array defaults Fixes langgenius#28546 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
When calling workflow API with missing optional fields, they should use configured default values instead of becoming null.
Changes:
Fixes #28546
🤖 Generated with Claude Code
Important
Fixes #<issue number>.Summary
close [#28546 ]
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods