Move order by direction check to more appropriate location

langleyfoxall · Apr 7, 2020 · f371798 · f371798
1 parent 991b5c5
commit f371798
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/DataTableResponder.php b/src/DataTableResponder.php
@@ -144,13 +144,13 @@ private function buildQuery(Request $request)
         $orderByField = $request->get('orderByField');
         $orderByDirection = $request->get('orderByDirection');
 
-        if (!in_array(strtolower($orderByDirection), ['asc', 'desc'])) {
-            throw new InvalidArgumentException('Order by direction must be either asc or desc.');
-        }
-
         $query = $this->model->query();
 
         if ($orderByField && $orderByDirection) {
+            if (!in_array(strtolower($orderByDirection), ['asc', 'desc'])) {
+                throw new InvalidArgumentException('Order by direction must be either asc or desc.');
+            }
+
             if (in_array($orderByField, array_keys($this->orderByOverrides))) {
                 call_user_func_array(
                     $this->orderByOverrides[$orderByField],