Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPD: Decomposition of node-connecting components, addition of quadratic formulations #111

Merged
merged 14 commits into from
Oct 12, 2020

Conversation

tasseff
Copy link
Member

@tasseff tasseff commented Oct 12, 2020

Closes #106, closes #101, closes #98, closes #92, closes #89, closes #75, closes #28.

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #111 into master will decrease coverage by 6.02%.
The diff coverage is 84.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   86.18%   80.15%   -6.03%     
==========================================
  Files          24       27       +3     
  Lines        2294     2207      -87     
==========================================
- Hits         1977     1769     -208     
- Misses        317      438     +121     
Impacted Files Coverage Δ
src/WaterModels.jl 100.00% <ø> (ø)
src/util/compute_cuts.jl 0.00% <0.00%> (ø)
src/util/unbinarize.jl 0.00% <0.00%> (ø)
src/prob/des.jl 66.66% <58.62%> (-8.34%) ⬇️
src/util/obbt.jl 79.55% <70.65%> (-12.12%) ⬇️
src/core/data.jl 59.50% <80.95%> (+11.36%) ⬆️
src/core/ref.jl 87.31% <81.08%> (-4.56%) ⬇️
src/io/epanet.jl 71.00% <81.39%> (-2.35%) ⬇️
src/form/directed_flow.jl 89.15% <85.00%> (-7.32%) ⬇️
src/core/constraint_template.jl 80.24% <90.65%> (-14.89%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c7d8fc...5652aa8. Read the comment docs.

@tasseff tasseff changed the title Decomposition of node-connecting components, addition of quadratic formulations. UPD: Decomposition of node-connecting components, addition of quadratic formulations. Oct 12, 2020
@tasseff tasseff changed the title UPD: Decomposition of node-connecting components, addition of quadratic formulations. UPD: Decomposition of node-connecting components, addition of quadratic formulations Oct 12, 2020
@tasseff tasseff merged commit fdbe818 into master Oct 12, 2020
@tasseff tasseff deleted the valves branch October 13, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment