Metadata flags #61
Open
Metadata flags #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument ordering in the estimate methods to be more consistent
…m EstimateMetaData
…spective estimator tool
…en functions and classes -> nsteps
…rizationMetaData in estimate_trotter()
|
I don't see a commit that merges dev to this branch. Has that been merged in? |
…lso fixed the convention with using objects as arguments and defaulting them to None
…fied, added -d/--directory argument to specify
JonhasSC
requested changes
Nov 14, 2024
scripts/AP-RE.py
Outdated
| pathways = [ | ||
| pathway_info( | ||
| pathway=[27, 1, 14, 15, 16, 24, 25, 26], | ||
| fname='water_oxidation_Co2O9H12.xyz' | ||
| fname=pathway_directory+'water_oxidation_Co2O9H12.xyz' |
There was a problem hiding this comment.
instead of string concatenating, its best to do string formatting.
fname = f'{pathway_directory}/[filename here]'
| gsee_args=gsee_args, | ||
| init_state=init_state, | ||
| precision_order=1, | ||
| phase_offset=phase_offset, | ||
| bits_precision=bits_precision, | ||
| circuit_name=name, | ||
| metadata=metadata, | ||
| is_extrapolated=is_extrapolated, |
| @@ -55,28 +56,36 @@ def main(args): | |||
| print('starting') | |||
| value_per_circuit = value/repetitions | |||
| value_per_circuit=6 | |||
| dicke_metadata = EstimateMetaData( | |||
| #TODO: See if I need to refactor the size string to include the variable names | |||
There was a problem hiding this comment.
What's the purpose of this comment?
…assed it into all calls of clifford_plus_t_direct_transform
…racy as an argument to estimate_trotter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR to merge into dev instead of main.
Added flags like is_extrapolated to the metadata per Zach's issue #51. Implemented these through three new metadata objects. I also made some of the variable naming more consistent. I also integrated these changes into the scripts and python notebooks and verified that they ran without error.