Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve obstacles to jitting of some functionals #467

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Conversation

bwohlberg
Copy link
Collaborator

Resolve obstacles to jitting of some functionals and add corresponding tests.

@bwohlberg bwohlberg added the improvement Improvement of existing code, including addressing of omissions or inconsistencies label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #467 (7672f75) into main (092a917) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   94.59%   94.59%   +0.01%     
==========================================
  Files          89       89              
  Lines        5541     5547       +6     
==========================================
+ Hits         5241     5247       +6     
  Misses        300      300              
Flag Coverage Δ
unittests 94.59% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scico/functional/_norm.py 100.00% <100.00%> (ø)

@bwohlberg
Copy link
Collaborator Author

For the record, there was a discussion of the apparent lack of support for jitting of static methods: jax-ml/jax#7702.

@bwohlberg bwohlberg merged commit a03aa56 into main Nov 9, 2023
19 checks passed
@bwohlberg bwohlberg deleted the brendt/jit-norm branch November 9, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants