Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XRayTransform2D projection dtype and docs #557

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

Michael-T-McCann
Copy link
Contributor

resolves #542
hypothesized to resolve a warning about dtypes from the tests

@bwohlberg

This comment was marked as outdated.

@bwohlberg
Copy link
Collaborator

I noticed that the public versions of these methods

def project(self, im: ArrayLike) -> snp.Array:
"""Compute X-ray projection."""
return XRayTransform2D._project(im, self.x0, self.dx, self.y0, self.ny, self.angles)
def back_project(self, y: ArrayLike) -> snp.Array:
"""Compute X-ray back projection"""
return XRayTransform2D._back_project(y, self.x0, self.dx, self.nx, self.y0, self.angles)

are not fully document, while the private versions are. It wouldn't hurt to add the missing docs in this PR.

@bwohlberg bwohlberg added documentation Improvements or additions to documentation tests Pertaining to SCICO tests labels Oct 7, 2024
@Michael-T-McCann Michael-T-McCann merged commit 008697c into main Oct 15, 2024
18 checks passed
@Michael-T-McCann Michael-T-McCann deleted the mike/xray_tweaks branch October 15, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests Pertaining to SCICO tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parameter descriptions for linop.xray.Parallel2dProjector.__init__
2 participants