-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix XRayTransform2D
projection dtype and docs
#557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-T-McCann
force-pushed
the
mike/xray_tweaks
branch
from
October 1, 2024 23:02
6e40222
to
f03f1b8
Compare
Michael-T-McCann
force-pushed
the
mike/xray_tweaks
branch
from
October 1, 2024 23:03
f03f1b8
to
cf403bf
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bwohlberg
reviewed
Oct 2, 2024
bwohlberg
reviewed
Oct 2, 2024
bwohlberg
approved these changes
Oct 2, 2024
I noticed that the public versions of these methods scico/scico/linop/xray/_xray.py Lines 126 to 132 in c58b819
are not fully document, while the private versions are. It wouldn't hurt to add the missing docs in this PR. |
bwohlberg
added
documentation
Improvements or additions to documentation
tests
Pertaining to SCICO tests
labels
Oct 7, 2024
bwohlberg
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #542
hypothesized to resolve a warning about dtypes from the tests