Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XRayTransform boundary conditions #561

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Fix XRayTransform boundary conditions #561

merged 3 commits into from
Oct 15, 2024

Conversation

Michael-T-McCann
Copy link
Contributor

@Michael-T-McCann Michael-T-McCann commented Oct 15, 2024 •
edited
Loading

addresses #560

@bwohlberg bwohlberg added the bug Something isn't working label Oct 15, 2024
bwohlberg
bwohlberg approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@bwohlberg bwohlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming scico/test/linop/xray/test_xray.py to scico/test/linop/xray/test_xray_2d.py.

@Michael-T-McCann Michael-T-McCann enabled auto-merge (squash) October 15, 2024 17:42
@Michael-T-McCann Michael-T-McCann merged commit d3193ea into main Oct 15, 2024
18 checks passed
@Michael-T-McCann Michael-T-McCann deleted the mike/560 branch October 15, 2024 17:54
@bwohlberg bwohlberg linked an issue Oct 15, 2024 that may be closed by this pull request
XRayTransform2D fails adjoint test #560
Closed
@bwohlberg bwohlberg mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwohlberg bwohlberg bwohlberg approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XRayTransform2D fails adjoint test
2 participants
@Michael-T-McCann @bwohlberg