Skip to content

Update package.py for spiner feature changes #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2025
Merged

Update package.py for spiner feature changes #491

merged 4 commits into from
Apr 14, 2025

Conversation

jhp-lanl
Copy link
Collaborator

@jhp-lanl jhp-lanl commented Apr 11, 2025

PR Summary

When the last release was made, it looks like the spack dependencies weren't updated for the new spiner piecewise grids. This MR adjusts the spack logic so that newer versions correctly require newer spiner versions.

PR Checklist

  • N/A Adds a test for any bugs fixed. Adds tests for new features.
  • N/A Format your changes by using the make format command after configuring with cmake.
  • N/A Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@jhp-lanl jhp-lanl requested a review from Yurlungur April 11, 2025 19:00
@jhp-lanl
Copy link
Collaborator Author

@Yurlungur this is good to go as long as you agree with the spack logic

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Yurlungur Yurlungur merged commit a40403d into main Apr 14, 2025
9 checks passed
@Yurlungur Yurlungur deleted the jhp/spack branch April 14, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants