Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Power law opacity #51

Merged
merged 14 commits into from
Sep 26, 2024
Merged

Power law opacity #51

merged 14 commits into from
Sep 26, 2024

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Sep 25, 2024

Generic power law of density and temperature for the opacity.

pdmullen
pdmullen approved these changes Sep 25, 2024
View reviewed changes
Copy link

@pdmullen pdmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

singularity-opac/photons/powerlaw_opacity_photons.hpp Outdated Show resolved Hide resolved
singularity-opac/photons/powerlaw_opacity_photons.hpp Outdated Show resolved Hide resolved
Yurlungur
Yurlungur approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! This will be important for us in riot too.

test/test_powerlaw_opacities.cpp Outdated Show resolved Hide resolved
brryan
brryan commented Sep 25, 2024
View reviewed changes
cmake/SetupDeps.cmake Outdated Show resolved Hide resolved
brryan
brryan commented Sep 25, 2024
View reviewed changes
cmake/SetupFlags.cmake Outdated Show resolved Hide resolved
brryan
brryan commented Sep 25, 2024
View reviewed changes
cmake/SetupOptions.cmake Outdated Show resolved Hide resolved
@Yurlungur
Copy link
Collaborator

@brryan I think the build system should be fixed now... Can you give it a try?

@Yurlungur
Copy link
Collaborator

And if it works, merge at will :)

@brryan brryan merged commit 54875f5 into main Sep 26, 2024
1 check passed
@Yurlungur Yurlungur deleted the brryan/powerlaw branch September 28, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@pdmullen pdmullen pdmullen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brryan @Yurlungur @pdmullen @jonahm-LANL