Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues to work on my ceiba #16

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix some issues to work on my ceiba #16

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f9f504
use pathvalidate to make the local file path is valid
b04505009 Dec 8, 2020
4728d90
add another possible attribute '公布全班'
b04505009 Dec 8, 2020
5383f8c
add support for 旁聽courses, 暑期實習timeslots, 學生from NTUST or NTNU, 成績公佈w…
b04505009 Dec 8, 2020
58f5bf5
Add assertion len(student_rows) <= 12
Apr 5, 2021
915b6b4
Merge branch 'lantw44:master' into master
b04505009 Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ceiba_dl/config.py
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ class Config:
'attr_course_grades_show': '成績公布',
'value_course_grades_show_n': '不公布',
'value_course_grades_show_p': '公布個人',
'value_course_grades_show_a': '公布全班',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這個 commit 只增加設定值而無實際使用，是不是應該把「公布全班」相關的修改移來這個 commit，或是把這個 commit 併入下個 commit？理想上我們會希望每個 commit 都是一個完整、有意義、可以測試的修改。

'attr_course_grades_is_changed': 'is_changed',
'dir_course_homeworks': '作業區',
'file_course_homeworks_homework': '作業內容.json',
Expand Down