Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with inline not working on Toggle #337

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

holmesadam
Copy link
Contributor

The Toggle field is passed an is-inline option. is-inline is a boolean. optional() ignores null|false and therefore the Toggle can never be set as not inline i.e. ->inline(false)

This fix addresses that error.

Copy link

what-the-diff bot commented Dec 13, 2024

PR Summary

  • Safeguarded the use of 'is-inline' option
    Ensured that this option was actually available before utilizing it in the configuration of the component. This was achieved by changing the condition to check if 'is-inline' exists first.

@atmonshi atmonshi merged commit debcb98 into lara-zeus:3.x Dec 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants