Ensure migrations use the correct configured database connection #134
+38
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would make this migration we publish extend a |
|
Please mark as ready for review when the requested changes have been made. |
|
Thank you. I’ve implemented the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the migration for Pennant use the configured database connection.
Why is this needed?
Currently, the migration does not explicitly set the database connection, which causes issues when using a custom connection for Pennant. As a result, migrations may run on the default connection instead of the intended one.
How does this fix it?
getConnection()to ensure the migration runs on the correct database connection.Let me know if any adjustments are needed.