Update reverb.php to include redis scheme option #349
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the scheme option to the server when scaling reverb. Scheme option is used in the function to build the final redisURL, but not exposed as an option here. Often the scheme is TLS on production, making the default not work in this case, and there is no documentation on it.
|
You can add this to your application if you need it 👍 |
|
Yes true, but figuring out this option exists requires you to browse reverbs redis client code, and finding out that this is a valid param. Same as driver. I think it could make it easier for other devs, who need that option in their codebase. So i dont see why adding it would hurt anybody |
|
Or atleast add it to the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the scheme option to the server when scaling reverb. Scheme option is used in the function to build the final redisURL, but not exposed as an option here. Often the scheme is TLS on production, making the default not work in this case, and there is no documentation on it.