[Typesense] Sync server state in getOrCreateCollectionFromModel #845 #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the `getOrCreateCollectionFromModel` method in `TypesenseEngine` to verify if a collection exists on the server. If not found, it is created. This ensures consistency between the worker and server states.
refactor: remove uneeded cast of flag The collectionExists flag was already cast as false, so recasting it serves no purpose
saibotk
added a commit
to saibotk/scout
that referenced
this pull request
Jul 12, 2024
In //laravel#820 we introduced an exists check method, which then lead to static state issues as described in laravel#845 Those where addressed in laravel#846 But now that the function always double-checks the existence, we can remove the exists check entirely and only rely on the Typesense server response for this state. This "fixes" issues where the server already has a collection and the client would try to recreate it. E.g. when it has flushed the index and another process or worker then creates the collection.
saibotk
added a commit
to saibotk/scout
that referenced
this pull request
Jul 12, 2024
In laravel#820 we introduced an exists check method, which then lead to static state issues as described in laravel#845 Those where addressed in laravel#846 But now that the function always double-checks the existence, we can remove the exists check entirely and only rely on the Typesense server response for this state. This "fixes" issues where the server already has a collection and the client would try to recreate it. E.g. when it has flushed the index and another process or worker then creates the collection.
saibotk
added a commit
to saibotk/scout
that referenced
this pull request
Jul 12, 2024
In laravel#820 we introduced an exists check method, which then lead to static state issues as described in laravel#845 Those where addressed in laravel#846 But now that the function always double-checks the existence, we can remove the exists check entirely and only rely on the Typesense server response for this state. This "fixes" issues where the server already has a collection and the client would try to recreate it. E.g. when it has flushed the index and another process or worker then creates the collection.
saibotk
added a commit
to saibotk/scout
that referenced
this pull request
Jul 12, 2024
In laravel#820 we introduced an exists check method, which then lead to static state issues as described in laravel#845 Those where addressed in laravel#846 But now that the function always double-checks the existence, we can remove the exists check entirely and only rely on the Typesense server response for this state. This "fixes" issues where the server already has a collection and the client would try to recreate it. E.g. when it has flushed the index and another process or worker then creates the collection.
taylorotwell
added a commit
that referenced
this pull request
Aug 5, 2024
* refactor(typesense): remove unused exists checks In #820 we introduced an exists check method, which then lead to static state issues as described in #845 Those where addressed in #846 But now that the function always double-checks the existence, we can remove the exists check entirely and only rely on the Typesense server response for this state. This "fixes" issues where the server already has a collection and the client would try to recreate it. E.g. when it has flushed the index and another process or worker then creates the collection. * Update TypesenseEngine.php --------- Co-authored-by: Taylor Otwell <[email protected]>
|
Hi everybody, I'll be working on this ASAP, apologise for all the time taken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
getOrCreateCollectionFromModelmethod inTypesenseEngineto verify if a collection exists on the server. If not found, it is created. This ensures consistency between the worker and server, fixing queue workers not being able to import after flushing, as mentioned in #845.