Add clear-cache option to the Flush command #854
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flush command currently only removes the saved records from the database (or whatever data storage is used), it does not 'flush' records in the cache. As the name suggests, flush should remove the record from the db, and clear cache (probably more of a personal opinion - but since it's not flush-from-storage, it's just flush).
This is useful because (from my work experience), after flushing records, I always clear cache. And it'll be useful to just have that option along side the flush command. I'm not entirely sure how many people do the same, but i would personally find this useful.
Hopefully someone agrees.
it's a simple addition to the codebase, and i hope this explanation above is sufficient, otherwise, please let me know if there are any feedback/questions regarding this.
Fingers crossed