Fix virtual property serialization #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#108 ensured that there isn't an attempt to modify virtual properties during serialization. However, since this isn't done in
wrapClosures()andmapPointers(), this fix doesn't handle the following cases:wrapClosures()which always updates properties.mapPointers()only updates properties when the value is an array or an object.This PR uses the same virtual property check added to
mapByReference()in #108. The method was made static becausewrapClosures()is static.