fix: cannot assign Native to property of type Closure #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
When an object is serialized, all of its properties are recursively walked using reflection to wrap any closures. However, when an object has a property that's typed as
Closurethis causes a TypeError to be thrown (cannot assign Native to property of type Closure)---even on objects that implement__serializeand explicitly handle the closure.The fix is to simply check if an object implements
__serializeand if so, defer to that method for serialization instead of trying to still walk its properties.Thanks!