New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid translation files crashing the extension. #223

Open

AnouarTouati wants to merge 3 commits into laravel:main from AnouarTouati:fix-translation-crash

Contributor

AnouarTouati commented Jan 28, 2025 •

edited

Loading

This PR prevents extension from crashing when the user is working on translation files.

Fixes the following scenarios:

Creating an new php/json translation file
Invalid JSON structure
Syntax and runtime errors/exception in the PHP translation files

EDIT: I think this should fix #212

AnouarTouati added 3 commits

January 28, 2025 14:12


          Fix invalid translation files crashing the extension

fd07ee0


          remove some left overs from last commit

ad42788


          Switch to catching Throwables instead of Exceptions

58603ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet