Fix component and view discovery fails with symlinked packages outside project directory#603
Draft
N1ebieski wants to merge 1 commit intolaravel:mainfrom
Conversation
…ed packages outside project directory
Collaborator
|
Hey @N1ebieski, this is a great start. I think there is definitely a pathway for the extension to work with symlinked packages, but I'm not 100% sold on this specific approach just yet. I'd like to dive into a bit more research before we move forward with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #575
Current behaviour
LaravelVsCode::relativePathgenerates a relative path by removing the Laravel project'sbasePathfrom the given path. However, if the path does not contain thebasePath(for example, when it points to a location outside the project directory), the result is the absolute path within the repository for that view/component.My proposition
As a fallback in this situation,
LaravelVsCode::relativePathcould use another method based on segment comparison.Windows example:
BasePath:
D:\Work\livewire-starter-kitViewPath:
D:\Work\packages\author-name\package-name\resources\views\hello.blade.phpD:\Workis the common part, so it can be removed. Thelivewire-starter-kitsegment is missing in the view path, which means we need to go up one level (..).The final relative path would be:
..\packages\author-name\package-name\resources\views\hello.blade.php