Skip to content

tests: tpkey: make function without return value return void #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

a3f
Copy link
Contributor

@a3f a3f commented Jul 8, 2025

check_peer_ec_key_copy either terminates the program by calling exit() or it falls through the end of function without returning a value despite being defined to return int.

Given that the caller doesn't check its return value anyway, change its return type to void.

check_peer_ec_key_copy either terminates the program by calling exit()
or it falls through the end of function without returning a value
despite being defined to return int.

Given that the caller doesn't check its return value anyway, change its
return type to void.

Signed-off-by: Ahmad Fatoum <[email protected]>
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simo5 simo5 added the covscan-not-needed Covscan is not needed for this PR label Jul 8, 2025
@simo5 simo5 merged commit 0269849 into latchset:main Jul 8, 2025
65 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
covscan-not-needed Covscan is not needed for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants