Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few commits to run at ifca T2 and (post)process fastsim datasets #102

Open
wants to merge 144 commits into
base: master
Choose a base branch
from

Conversation

scodella
Copy link
Contributor

sorry in advance for the huge PR. Most of the changes regards my own  susy/fastsim files so they will not affect anyone. 

I briefly comment on the other changes. They are needed mostly to run at ifca T2 or to adapt the scripts to fastsim datasets, and are done as to be transparent to "common use". 

A) Changes needed to run at ifca T2 (ifca string randomly disappearing from node name...):

  • NanoGardener/python/framework/PostProcMaker.py
  • NanoGardener/python/framework/Sites_cfg.py 
  • Tools/python/batchTools.py 
  • Tools/python/commonTools.py

B) Changes needed to (post)process fastsim datasets:

  • NanoGardener/python/modules/TrigMaker.py -> fastsim datasets do not have hlt info

  • NanoProducer/python/NanoProdMaker.py -> modifies cfg to process fastsim datasets, possibly reading jec from fastsim db files. Both option activated by key added in  fastsim production (see next item), not affecting other  datasets.

  • NanoProducer/python/Productions_cfg.py -> trivially adding productions for fastsim

C) Change to a common file, but trasparent by  default

  • ShapeAnalysis/scripts/mkDatacards.py -> options to add 'limits' to the rate param or to 'bond' the rate to a formula. Both options activated by optional keys in the nuisance dictionary.

D) Change that affects everybody

  • NanoGardener/python/modules/LeptonSel.py -> I think that isVeto should be filled after 'if not isClean_lep: continue' to be consistent with other Lep_Tags variables (but anyway I do not really use this variable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant