-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few commits to run at ifca T2 and (post)process fastsim datasets #102
Open
scodella
wants to merge
144
commits into
latinos:master
Choose a base branch
from
scodella:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry in advance for the huge PR. Most of the changes regards my own susy/fastsim files so they will not affect anyone.
I briefly comment on the other changes. They are needed mostly to run at ifca T2 or to adapt the scripts to fastsim datasets, and are done as to be transparent to "common use".
A) Changes needed to run at ifca T2 (ifca string randomly disappearing from node name...):
B) Changes needed to (post)process fastsim datasets:
NanoGardener/python/modules/TrigMaker.py -> fastsim datasets do not have hlt info
NanoProducer/python/NanoProdMaker.py -> modifies cfg to process fastsim datasets, possibly reading jec from fastsim db files. Both option activated by key added in fastsim production (see next item), not affecting other datasets.
NanoProducer/python/Productions_cfg.py -> trivially adding productions for fastsim
C) Change to a common file, but trasparent by default
D) Change that affects everybody