tmpfile per nuisance for tree type nuisances #149
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amassiro
reviewed
May 28, 2020
Contributor
amassiro
left a comment
amassiro
left a comment
There was a problem hiding this comment.
Seems ok to me (I'm not sure how the "review" works on github), but I'm not too much into multiraw stuff yet, and there may be some reason behind the current structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid too large tmp file , use only one tmp file per nuisance in tree-based type.
In old version, tmp file contains all trees of tree-based nuisances and then make shape one by one.
In this PR, a tmp file is made for a nuisance and removed after making shape of the nuisance.
I will save working space to 1/[the number of tree-based nuisances].