Skip to content

Development branch - amassiro #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Development branch - amassiro #74

wants to merge 3 commits into from

Conversation

@amassiro
Copy link

@amassiro amassiro commented Oct 16, 2025 •
edited
Loading

Changes:

  • add new options for interface for histogram production and checks
  • tiny change in colours while checking running jobs (I could not see the yellow, I put red for the running ones :) )
  • in mkplot, copy automatically index.php file. We should add a default index.php in plotconfigurationsrun3 main folder too

Do not merge this yet, ... more to come ...

NTrevisani
NTrevisani reviewed Nov 5, 2025
View reviewed changes
mkShapesRDF/shapeAnalysis/mkShapesRDF.py
help="Resubmit jobs, 1 resubmit finished jobs with errors, 2 resubmit running jobs",
required=False,
default="0",
default="0", # default 0 ?? Why not "1" as default?
Copy link

@NTrevisani NTrevisani Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess "0" is the default because you do not want to resubmit jobs if they crashed because of errors in the configuration. We can then just check what caused the jobs to crash, and if there are errors, we fix them. Otherwise, we resubmit.

Copy link
Author

@amassiro amassiro Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my question is: if I run "--resubmit" it means that I want to resubmit ... otherwise I run the command "--check".
Actually, the "resubmit 0" does nothing in the code ...

Copy link

@NTrevisani NTrevisani Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, I just got confused. I was thinking at 'operation' mode rather than 'resubmit'. We can change it to 1, then.

@NTrevisani
Copy link

NTrevisani commented Nov 11, 2025

Thank you @amassiro. I suggest we merge the PR at this point. Further developments will go in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NTrevisani NTrevisani NTrevisani left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amassiro @NTrevisani