Refactor CSRF token handling and utility functions #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated randomString function to generate bytes based on length directly. Modified verifyToken function to accept saltLength parameter and adjusted logic accordingly. Enhanced generateSecret function to ensure correct length after encoding. Added getHeaderValue function for extracting CSRF token from headers. Updated defaultValue function to accommodate request object.
Owner
|
Hey there @Sachin-8125. #2 Is already closed, so someone else will get the bounty. I don't think the change in this PR is needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated randomString function to generate bytes based on length directly. Modified verifyToken function to accept saltLength parameter and adjusted logic accordingly. Enhanced generateSecret function to ensure correct length after encoding. Added getHeaderValue function for extracting CSRF token from headers. Updated defaultValue function to accommodate request object.