Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres: force generic plan for better nullability inference. #3541

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+22 −1
Open

Postgres: force generic plan for better nullability inference. #3541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59399b9
Postgres: force generic plan when describing statement with args
joeydewaal Oct 5, 2024
4ceb879
cargo fmt
joeydewaal Oct 5, 2024
5bba30d
Postgres: set plan_cache_mode in transaction
joeydewaal Oct 5, 2024
819f189
Postgres: only set force_generic_plan for versions that support it
joeydewaal Oct 5, 2024
12c2986
Postgres: reduce database calls in query macro's
joeydewaal Oct 8, 2024
0e2ec96
Postgres: set generic execution plan only in query macro
joeydewaal Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 21 additions & 1 deletion sqlx-macros-core/src/database/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,27 @@ impl<DB: DatabaseExt> CachingDescribeBlocking<DB> {
let conn = match cache.entry(database_url.to_string()) {
hash_map::Entry::Occupied(hit) => hit.into_mut(),
hash_map::Entry::Vacant(miss) => {
miss.insert(DB::Connection::connect(database_url).await?)
let conn = miss.insert(DB::Connection::connect(database_url).await?);

#[cfg(feature = "postgres")]
if DB::NAME == sqlx_postgres::Postgres::NAME {
conn.execute(
"
DO $$
BEGIN
IF EXISTS (
SELECT 1
FROM pg_settings
WHERE name = 'plan_cache_mode'
) THEN
SET SESSION plan_cache_mode = 'force_generic_plan';
END IF;
END $$;
",
)
.await?;
}
conn
}
};

Expand Down