feat: Add inline fixer configuration support #10

zmdavis · 2025-08-07T18:37:06Z

Implement a cleaner configuration format that eliminates the need to specify fixers twice. Users can now mix simple fixer names with inline configuration objects:

Add FixerConfig interface and FixerItem union type
Update configuration parsing to handle mixed string/object arrays
Maintain full backward compatibility with legacy format
Add comprehensive documentation with examples
Update all TypeScript types for better type safety

Example of new format:

{
  "fixers": [
    "eslint",
    {
      "name": "prettier",
      "command": ["yarn", "prettier:write:path"],
      "appendPaths": true
    }
  ]
}

Implement a cleaner configuration format that eliminates the need to specify fixers twice. Users can now mix simple fixer names with inline configuration objects: - Add FixerConfig interface and FixerItem union type - Update configuration parsing to handle mixed string/object arrays - Maintain full backward compatibility with legacy format - Add comprehensive documentation with examples - Update all TypeScript types for better type safety Example of new format: ```json { "fixers": [ "eslint", { "name": "prettier", "command": ["yarn", "prettier:write:path"], "appendPaths": true } ] } ``` 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

Add comprehensive migration guide showing how to convert from the legacy format to the new inline fixer configuration format. Includes: - Step-by-step migration instructions - Before/after examples for common scenarios - Quick reference mapping table - Backward compatibility notes - Complete real-world migration example 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

Update all .felixrc.json files and documentation examples to demonstrate the new inline fixer configuration format: - Update root .felixrc.json to use inline format - Update examples/.felixrc.json with comprehensive inline examples - Update README.md configuration examples - Add mixed format examples to show flexibility - Maintain backward compatibility notes This provides users with working examples of the new format while keeping the repository's own configuration up-to-date.

Add a simple .felixrc.json example alongside the advanced ones to show that basic usage remains clean and straightforward with the new inline format. Shows progression from simple string array to advanced inline objects.

Rebuild the action distribution to include all TypeScript changes for the new inline fixer configuration format.

Resolve conflicts by accepting main branch changes in dist/ files. Distribution will be rebuilt to include all inline fixer config changes.

Rebuild action distribution to include: - Inline fixer configuration changes - Latest main branch improvements (hasFailures field) - Properly generated source maps

Copilot

Pull Request Overview

This PR introduces a cleaner inline configuration format for Fix-it Felix that eliminates the need to specify fixers twice. Users can now mix simple fixer names with inline configuration objects while maintaining full backward compatibility with the legacy format.

Adds FixerConfig interface and FixerItem union type for better type safety
Updates configuration parsing to handle mixed string/object arrays in the fixers property
Provides comprehensive migration documentation and examples

Reviewed Changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/types.ts`	Refactors type definitions to support new `FixerConfig` interface and `FixerItem` union type
`src/fixers/*.ts`	Updates fixer constructors to use strongly-typed `FixerConfig` instead of `any`
`src/config.ts`	Implements parsing logic for new inline configuration format with legacy fallback
`src/felix.ts`	Updates type annotations to use new `FixerConfig` type
`examples/.felixrc.json`	Demonstrates new inline configuration format
`docs/MIGRATION.md`	Comprehensive migration guide from legacy to inline format
`docs/CONFIGURATION.md`	Updated documentation with examples of both formats
`README.md`	Updated examples to showcase new inline configuration
`.felixrc.json`	Migrated project's own configuration to new format

src/fixers/base.ts

src/config.ts

src/types.ts

- Remove redundant command fallback in BaseFixer (already validated by hasCustomCommand) - Replace 'unnamed-fixer' fallback with proper error throwing for inline configs - Add InlineFixerConfig type requiring name property for better type safety - Add validation error handling in getFixers() method - Update documentation to emphasize required name property - Rebuild distribution with improvements

Rebuild action distribution to include: - Inline fixer configuration feature with PR feedback addressed - Latest main branch improvements and bug fixes - Properly generated source maps with all changes combined

- Keep inline fixer configuration format in .felixrc.json - Add missing type imports in config.ts and felix.ts - Extend FixerConfig interface with oxlint-specific properties - Rebuild distribution files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-07T23:56:30Z

src/types.ts

+  extensions?: string[]
+  paths?: string[]
+  command?: string[]
+  appendPaths?: boolean


The env property for environment variables lacks documentation. Add a comment explaining that these environment variables are applied when executing custom commands.

Suggested change

appendPaths?: boolean

appendPaths?: boolean

/**

* Environment variables to set when executing custom commands.

* These variables are applied only during the execution of the command specified in `command`.

*/

Copilot · 2025-11-07T23:56:31Z

src/config.ts

 import * as core from '@actions/core'
 import * as fs from 'fs'
-import { FelixConfig, FelixInputs } from './types'
+import * as path from 'path'


The path import is unused in this file and should be removed to keep imports clean.

Suggested change

import * as path from 'path'

Copilot · 2025-11-07T23:56:31Z

.felixrc.json

+      "appendPaths": false
+    }
+  ],
+  "paths": ["src", "examples", "tests", "*.md", "jest.config.js", "test-felix.js"],


[nitpick] The paths array includes specific file patterns (*.md, jest.config.js, test-felix.js) mixed with directory patterns. Consider using more consistent glob patterns like 'src/' and 'examples/' as shown in other examples for better maintainability.

Suggested change

"paths": ["src", "examples", "tests", "*.md", "jest.config.js", "test-felix.js"],

"paths": ["src/**", "examples/**", "tests/**", "**/*.md", "jest.config.js", "test-felix.js"],

- Add documentation for env property in FixerConfig interface - Remove unused path import from src/config.ts - Update glob patterns in .felixrc.json for consistency (src/** instead of src) - Remove unused type imports to fix linting errors - Rebuild distribution files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

zmdavis and others added 7 commits August 7, 2025 11:36

docs: Add simple configuration example to README

b6cac26

Add a simple .felixrc.json example alongside the advanced ones to show that basic usage remains clean and straightforward with the new inline format. Shows progression from simple string array to advanced inline objects.

build: Update distribution with inline fixer configuration changes

eb0a799

Rebuild the action distribution to include all TypeScript changes for the new inline fixer configuration format.

Merge main into feature/inline-fixer-config

488ee7e

Resolve conflicts by accepting main branch changes in dist/ files. Distribution will be rebuilt to include all inline fixer config changes.

build: Rebuild distribution after main branch merge

dd34df2

Rebuild action distribution to include: - Inline fixer configuration changes - Latest main branch improvements (hasFailures field) - Properly generated source maps

zmdavis force-pushed the feature/inline-fixer-config branch from 1376dc7 to dd34df2 Compare August 7, 2025 18:44

🤖 Fix-it Felix: Auto-fix formatting issues

7eb508f

zmdavis requested a review from Copilot August 7, 2025 18:52

Copilot AI reviewed Aug 7, 2025

View reviewed changes

src/fixers/base.ts Outdated Show resolved Hide resolved

src/config.ts Outdated Show resolved Hide resolved

src/types.ts Show resolved Hide resolved

zmdavis and others added 4 commits August 7, 2025 12:14

Merge main branch with latest improvements

6f2fa7a

build: Rebuild distribution after merging latest main changes

4f02a9e

Rebuild action distribution to include: - Inline fixer configuration feature with PR feedback addressed - Latest main branch improvements and bug fixes - Properly generated source maps with all changes combined

zmdavis requested a review from Copilot November 7, 2025 23:55

Copilot AI reviewed Nov 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add inline fixer configuration support #10

feat: Add inline fixer configuration support #10

Uh oh!

zmdavis commented Aug 7, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 7, 2025

Uh oh!

Copilot AI Nov 7, 2025

Uh oh!

Copilot AI Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	"paths": ["src", "examples", "tests", "*.md", "jest.config.js", "test-felix.js"],
	"paths": ["src/", "examples/", "tests/", "/*.md", "jest.config.js", "test-felix.js"],

feat: Add inline fixer configuration support #10

Are you sure you want to change the base?

feat: Add inline fixer configuration support #10

Uh oh!

Conversation

zmdavis commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zmdavis commented Aug 7, 2025 •

edited

Loading