chore: Fix test builds with meck incompatibilities. #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Oct 18, 2024
rebar.config
Outdated
| {bookish_spork, "0.3.5"}, | ||
| {cowboy, "2.8.0"}, | ||
| {meck, "0.9.2"} | ||
| {meck, { git, "[email protected]:eproxus/meck.git", {ref, "dfb47c544bdf14b5c26ff2651cf9339dbbe2f50e"}}} |
Member
Author
There was a problem hiding this comment.
This SHA has some OTP/27 fixes.
kinyoklion
changed the title
kinyoklion
commented
Oct 18, 2024
Makefile
Outdated
| #This is used on CircleCI because the Redis Docker container is already started unlike the local tests command | ||
| ci-tests: | ||
| @$(REBAR3) ct --dir="test,test-redis" --logdir logs/ct | ||
| @if [ "$(ERL_VERSION)" -ge "25" ]; then\ |
Member
Author
There was a problem hiding this comment.
Here things get ugly. Need two different versions of meck to keep things working.
kinyoklion
commented
Oct 18, 2024
| fail-fast: false | ||
| matrix: | ||
| versions: | ||
| - {os: 'ubuntu-20.04', otp: '21.x', rebar: '3.15.2'} |
Member
Author
There was a problem hiding this comment.
I'm having to drop CI for 21.
Member
Author
There was a problem hiding this comment.
It should all still work, but a version of meck that works with 21 will not work with 27.
kinyoklion
commented
Oct 18, 2024
Member
Author
There was a problem hiding this comment.
Second problem. meck is really unhappy about mocking rand now. So I changed this to allow the randomization function to be injected.
kinyoklion
commented
Oct 18, 2024
| tests: | ||
| docker run --name ld-test-redis -p 6379:6379 -d redis | ||
| @$(REBAR3) ct --dir="test,test-redis" --logdir logs/ct --cover | ||
| @$(REBAR3) ct --dir="test,test-redis" --logdir logs/ct |
Member
Author
There was a problem hiding this comment.
First problem is that it doesn't work with the cover arguments in current OTP 27.
kinyoklion
changed the title
keelerm84
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around: eproxus/meck#248