-
Notifications
You must be signed in to change notification settings - Fork 0
feat: [REL-10964] add Session Replay capabilities to Toolbar #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
nieblara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are looking cool here!
packages/toolbar/src/core/ui/Toolbar/context/InternalClientProvider.tsx
Outdated
Show resolved
Hide resolved
packages/toolbar/src/core/ui/Toolbar/context/InternalClientProvider.tsx
Outdated
Show resolved
Hide resolved
|
the session replay lib might be too new for the version of the sdk we have right now! |
d4008ce to
5557a38
Compare
I tried to find docs to check this and even looked into the source code but couldn't find anything to indicate this 🤔 Is there somewhere you read/saw this that you could share? |
Add observability and Session Replay integration to the toolbar's internal LaunchDarkly client. Session Replay is controlled via a feature flag.
5557a38 to
8783e6e
Compare
- Move session replay flag key to a constant
8783e6e to
715d7fb
Compare
- Added '@launchdarkly/observability' dependency to the project. - Updated InternalClientProvider to initialize and manage Observability alongside Session Replay. - Refactored telemetry handling to include observability monitoring.
cspath1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super excited to have this ready to go!
| privacySetting: 'default', | ||
| ...(backendUrl && { backendUrl }), | ||
| // Block everything except the toolbar's shadow DOM | ||
| blockSelector: 'body > *:not(#ld-toolbar)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So happy we are able to utilize this!
Add observability and Session Replay integration to the toolbar's internal LaunchDarkly client. Session Replay is controlled via a feature flag.
Description
This PR adds Session Replay capabilities to the Developer Toolbar, enabling observability.
What does this PR do?
Integrates LaunchDarkly's Session Replay plugin into the toolbar's internal client, controlled by a feature flag. Session Replay runs only in the toolbar's internal LaunchDarkly client context and uses the 'default' privacy setting.
Type of Change
Screenshots/Videos
Related Jira issue: REL-10964: Add Session Replay capabilities to the Developer Toolbar