-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Support of multiple connectors #803
base: main
Are you sure you want to change the base?
Conversation
(This is my first proper interaction in this repo, so please feel free to ignore.) It looks like you're making good progress in multiple connector support. My main question is can you get the NumberOfConnectors from the charge point (getConfiguration), so you don't have to set it manually? I guess this would probably be a total pain, so it might be worth leaving out? |
@ernst77 There are still some linting issues, and a test failure. These need to be fixed before I can merge the changes. |
Stale pull request message |
Hey! Are linting errors and tests (and now merge conflicts) the only thing stopping this from getting merged? Does the feature itself work? Asking to set expectations and see if I can help as well. |
We have a rather large update pending (support for ocpp v2), better wait until that has been merged to main. |
I'll hold off, thanks for sharing the message here as well. I'll meanwhile get more familiar with the protocol and try and see if I can look at some traffic that is happening currently between the server and the charger. The main question still stands, though - besides the hygiene (tests, linting etc.), did the PR actually manage to get multiple chargers to work properly? |
This will provide support for chargers with multiple connectors.
As mentioned in #796 #801 #594 #792 #798
Thanks for the code https://github.com/jthun, I've made some modifications and put it up to date with the current code.
If the separation of connectors is not needed when connector count
<
2. Let me know We could addif
and merge all properties tocharger
how it used to be done.