Format gui xmls #10743
Open
Format gui xmls #10743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightenom
reviewed
Mar 31, 2025
| <text size="110 11" pos="90 80" color="black" label="§n$(com.minecolonies.coremod.gui.citizen.family.partner):§r"/> | ||
| <text id="partner" size="130 11" pos="50 95" color="black" textalign="MIDDLE"/> | ||
| <text color="black" label="§n$(com.minecolonies.coremod.gui.citizen.family.parents):§r" pos="90 40" size="110 11"/> | ||
| <text color="black" id="parentA" pos="50 51" size="130 11" textalign="MIDDLE"/> |
There was a problem hiding this comment.
can we have more logical sorting for these? like id, pos, size going first (id -> size -> pos seems to be the most used one)
There was a problem hiding this comment.
yeah, Id like id/pos/size by alphabet
There was a problem hiding this comment.
I can't configure it that much since prettier can only do it fully by alphabet. I did look at this myself but I'm not sure if it's doable
There was a problem hiding this comment.
I can try and do this, draft this PR for now, whilst I modify the prettier plugin in the source to allow for such an option
|
Waiting on prettier/plugin-xml#860 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Testing
Review please