Update JDK version in README.md #10883
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update developer setup instructions to refer to JDK 17
|
1.21 requires jdk 21, so might be worth going with that instead |
Yeaaah, I thought about that, but I wasn't sure where that branch is in terms of priority/releasability? There seems to be a pretty sizable gulf between the release/main and release/1.21 Maybe I can do a PR to that branch for a README update for jdk 21? |
|
I think we should mention both, telling ppl that version/main uses jdk 17 and version/1.21 jdk 21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update developer setup instructions to refer to JDK 17
Closes #10650
Changes proposed in this pull request
Testing
Review please