feat: remove SignUpByEmail #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank 沉寂 for bringing this to our attention.
weakish
commented
Nov 16, 2021
leancloud/users.go
Outdated
| "email": email, | ||
| "email": email, | ||
| // username & password fields are required for all users | ||
| "username": email, |
There was a problem hiding this comment.
如果不指定 username，云端会报错
{"code":200,"error":"Username is missing or empty."}不过其实我不是很确定 SignUpByEmail 这个接口当时引入的动机，其他 SDK 都没有凭邮箱注册的接口（只有凭邮箱登录的接口）。
可能这个留给应用层面决定更好，因为如果应用提供凭邮箱注册的功能，它可能设计成需要另外填用户名，也可能设计成用户名和邮箱一样，也可能设计成用户名随机生成。
There was a problem hiding this comment.
我也没有印象，如果其他 SDK 都没有是不是应该去掉 ....
There was a problem hiding this comment.
去掉了（反正之前有 bug 也不能用，去掉也不破坏兼容性）
to be consistent with other SDKs. This method did not work before so the removal does not introduce a breaking change.
weakish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank 沉寂 for bringing this to our attention.