Fix constants ignoring ExcludeFromContractsGenerationAttribute #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 81.26% 82.07% +0.80%
==========================================
Files 34 34
Lines 993 993
Branches 117 117
==========================================
+ Hits 807 815 +8
+ Misses 141 133 -8
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jakubfijalkowski
approved these changes
May 20, 2025
I'm holding off with that until #167 is merged to have a general idea about what will get into 4.0.0 release. |
Saancreed
force-pushed
the
analyzer-issues
branch
from
ec3e2a9 to
136568f
Compare
Saancreed
force-pushed
the
fix-constant-exclusions
branch
from
079ee8e to
e4e5cf3
Compare
Saancreed
force-pushed
the
analyzer-issues
branch
from
136568f to
ce2e5d0
Compare
Saancreed
force-pushed
the
fix-constant-exclusions
branch
from
e4e5cf3 to
470abb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Komoszek This one is dedicated for you.
Fixes #164.