Skip to content

Add some extra logging and cleanup MSBuild integration #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 30, 2025
Merged

Conversation

Saancreed
Copy link
Member

Helps a lot when debugging weird setup issues; includes some minor cleanup to our MSBuild integration.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025

Codecov Report

Attention: Patch coverage is 30.43478% with 32 lines in your changes missing coverage. Please review.

Project coverage is 78.15%. Comparing base (d2604e8) to head (cb5cb02).

Files with missing lines Patch % Lines
...actsGenerator/Compilation/MSBuild/MSBuildHelper.cs 30.43% 27 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   81.26%   78.15%   -3.12%     
==========================================
  Files          34       33       -1     
  Lines         993      984       -9     
  Branches      117      119       +2     
==========================================
- Hits          807      769      -38     
- Misses        141      167      +26     
- Partials       45       48       +3     
Flag Coverage Δ
net8.0 78.15% <30.43%> (-3.10%) ⬇️
net9.0 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented May 28, 2025

Test Results

  2 files  ±0    2 suites  ±0   44s ⏱️ +2s
 82 tests ±0   82 ✅ ±0  0 💤 ±0  0 ❌ ±0 
178 runs  ±0  178 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cb5cb02. ± Comparison against base commit d2604e8.

♻️ This comment has been updated with latest results.

Copy link
Member

@jakubfijalkowski jakubfijalkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:, but can we get an example of one of the weird situations?

@Saancreed
Copy link
Member Author

Saancreed commented May 29, 2025

Some that come to mind:

  1. Ubuntu machine that went through release upgrade and now has a mix of packages from p.m.c and Canonical repos.
  2. Some outdated local installations that export DOTNET_ROOT and interfere with discovery of other SDK versions.
  3. Stray global.json forcing use of .NET tool on previous framework version, preventing MSBuild Locator from reporting newer SDK.
  4. Having installed recent enough runtime but not recent enough SDK. Uncommon, but you never know.

And I wouldn't be surprised if there was more of them.

Base automatically changed from analyzer-issues to main May 30, 2025 12:36
@Saancreed Saancreed merged commit 4bc5807 into main May 30, 2025
4 checks passed
@Saancreed Saancreed deleted the extra-logs branch May 30, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants