Add some extra logging and cleanup MSBuild integration#170
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 81.26% 78.15% -3.12%
==========================================
Files 34 33 -1
Lines 993 984 -9
Branches 117 119 +2
==========================================
- Hits 807 769 -38
- Misses 141 167 +26
- Partials 45 48 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jakubfijalkowski
approved these changes
May 29, 2025
Member
jakubfijalkowski
left a comment
There was a problem hiding this comment.
, but can we get an example of one of the weird situations?
Member
Author
|
Some that come to mind:
And I wouldn't be surprised if there was more of them. |
ec3e2a9 to
136568f
Compare
136568f to
ce2e5d0
Compare
So they aren't distributed with the tool if any other package happens to depend on them transitively.
And migrate launch configuration to net9.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps a lot when debugging weird setup issues; includes some minor cleanup to our MSBuild integration.