Initial implementation of v3 #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Komoszek
reviewed
Sep 11, 2023
| @@ -0,0 +1,14 @@ | |||
| { | |||
There was a problem hiding this comment.
No local-publish like in the corelibrary? 🤔
There was a problem hiding this comment.
I forgot about that, I will add it shortly
konowrockis
reviewed
Sep 11, 2023
konowrockis
approved these changes
Sep 11, 2023
Komoszek
reviewed
Sep 11, 2023
Comment on lines
+13
to
+14
| "local-publish": { | ||
| "command": "npx nx run-many -t publish --registry=http://localhost:4873/ --ver={args.ver} --tag={args.tag}" |
There was a problem hiding this comment.
This by itself is not enough. You also have to update publish target in package's project.json and update (use corelibrary version) publish.mjs in tools/scripts
Komoszek
approved these changes
Sep 28, 2023
Comment on lines
+24
to
+28
| run: npx nx run-many -t test | ||
| - name: Build & Publish | ||
| run: | ||
| npx nx run-many -t publish --registry=npm --ver=${{ format('{0}', | ||
| steps.package-version.outputs.current-version)}} --tag=latest |
There was a problem hiding this comment.
You might want to match current release workflow from corelibrary, but there is only one package in this repo so there shouldn't be any issues with current version.
kamilgacan
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.