Skip to content

feat: fix some issues with equals t => tac #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

plp127
Copy link

@plp127 plp127 commented Jun 26, 2025

This PR fixed some issues with the conv tactic equals t => tac:

  • It gives bad error messages when t has the wrong type. For example,
    type mismatch
      this
    has type
      ?m.6391 = 1 : Prop
    but is expected to have type
      3 = ?m.6381 : Prop
    
  • The use of show (_ = $t) means that if t has exposed function dots, something like
    equals · => tacs
    
    will turn into
    tactic => show (_ = ·); next => tacs
    
    and (_ = ·) will elaborate as fun x => _ = x, which is probably unexpected.

@github-actions github-actions bot added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Jun 26, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Jun 27, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@fgdorais
Copy link
Collaborator

fgdorais commented Jul 3, 2025

This needs tests.

@fgdorais fgdorais added awaiting-author Waiting for PR author to address issues and removed awaiting-review This PR is ready for review; the author thinks it is ready to be merged. labels Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author Waiting for PR author to address issues builds-mathlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants