chore(hammer branch): bump v4.21.0 #54
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
Fin.ofNat'
->Fin.ofNat
Lean.Meta.AbstractMVarsResult
, renaming itsnumMVars
field tomvars
. This created a conflict in the function e.g.Auto.abstractMVars
. In fixing this issue, I found thatAuto.abstractMVars
probably intended to use the customAuto.AbstractMVars.AbstractMVarsResult
instead ofLean.Meta.AbstractMVarsResult
anyway, so I changed the signatures to use the former. The long-term solution would be to use onlyLean.Meta.AbstractMVarsResult
, but per my understanding the current one is used for a bug fix?MonadDeclNameGenerator
for generating auxiliary declaration names. As a result, theLean.mkAuxDecl
function is removed. I tried to modify Lean-auto to use the intended consequence of this abstraction in Lean core, which is to remove the fielddeclName?
inReif.ReifM
and rely on the (automatic) instanceMonadDeclNameGenerator Reif.ReifM
instead. (For example see the corresponding change inGrindM
in the linked commit above).