Skip to content

chore: upgrade stacks wallet-sdk to 3.4.0 #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
beguene wants to merge 1 commit into from
Closed

chore: upgrade stacks wallet-sdk to 3.4.0 #2303

beguene wants to merge 1 commit into from

Conversation

@beguene
Copy link
Contributor

@beguene beguene commented Mar 16, 2022 •
edited by github-actions bot
Loading

Try out this version of the Hiro Wallet - download extension builds.

Original PR #2289
Fixes #2283
and #2282

This is required to merge #2310

@fbwoolf @kyranjamie @He1DAr

@vercel
Copy link

vercel bot commented Mar 16, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/blockstack/stacks-wallet-web/Fv4XMzMQPuRiK9JkXjzHmoMm9Khb
✅ Preview: https://stacks-wallet-web-git-chore-wallet-sdk-3-4-0-blockstack.vercel.app

[Deployment for 282a1f4 failed]

@beguene beguene force-pushed the chore/wallet-sdk-3-4-0 branch from de9a027 to f48c7a3 Compare March 16, 2022 09:27
@vercel vercel bot temporarily deployed to Preview March 16, 2022 09:28 Inactive
@beguene beguene mentioned this pull request Mar 17, 2022
Closed
@vercel vercel bot temporarily deployed to Preview March 18, 2022 14:58 Inactive
@beguene beguene force-pushed the chore/wallet-sdk-3-4-0 branch from 19f3e51 to 72d036e Compare March 18, 2022 15:03
@vercel vercel bot temporarily deployed to Preview March 18, 2022 15:03 Inactive
@beguene beguene linked an issue Mar 18, 2022 that may be closed by this pull request
Address changes to stacks.js packages #2282
Closed
@beguene beguene marked this pull request as ready for review March 18, 2022 15:34
@andresgalante andresgalante removed the request for review from He1DAr March 21, 2022 14:36
@markmhendrickson
Copy link
Contributor

markmhendrickson commented Mar 21, 2022

@kyranjamie will review this PR then we'll move it to QA at which point we'll do a full regression test before releasing.

@pradel given a few other fires we're putting out at the moment, it's likely this won't all be completed until next week.

@pradel
Copy link
Contributor

pradel commented Mar 21, 2022 •
edited
Loading

Okay, thanks for the update

@pradel pradel mentioned this pull request Mar 21, 2022
Merged
@kyranjamie kyranjamie force-pushed the chore/wallet-sdk-3-4-0 branch from 72d036e to b396ef6 Compare March 22, 2022 19:38
@vercel vercel bot temporarily deployed to Preview March 22, 2022 19:38 Inactive
@kyranjamie kyranjamie force-pushed the chore/wallet-sdk-3-4-0 branch from b396ef6 to 8008501 Compare March 22, 2022 20:23
@vercel vercel bot temporarily deployed to Preview March 22, 2022 20:23 Inactive
@kyranjamie kyranjamie force-pushed the chore/wallet-sdk-3-4-0 branch from 8008501 to f070ccd Compare March 22, 2022 20:31
@vercel vercel bot temporarily deployed to Preview March 22, 2022 20:31 Inactive
@pradel @beguene
chore: upgrade stacks wallet-sdk to 3.4.0
282a1f4 
Add webpack aliases to esm instead of polyfill
closes #2283
closes #2282
@beguene beguene force-pushed the chore/wallet-sdk-3-4-0 branch from f070ccd to 282a1f4 Compare March 28, 2022 10:53
@vercel vercel bot temporarily deployed to Preview March 28, 2022 10:54 Inactive
@markmhendrickson
Copy link
Contributor

markmhendrickson commented Mar 28, 2022

We will begin QA'ing this week

@markmhendrickson markmhendrickson mentioned this pull request Apr 18, 2022
Merged
@markmhendrickson
Copy link
Contributor

markmhendrickson commented Apr 18, 2022

QA for this PR is awaiting inclusion of stx-labs/stacks.js#1230 in the underlying test app since we ran into problems since resolved by it during previous testing

@markmhendrickson
Copy link
Contributor

markmhendrickson commented Apr 28, 2022 •
edited
Loading

@beguene has this PR been merged and released already?

@beguene
Copy link
Contributor Author

beguene commented Apr 28, 2022

@markmhx This is obsolete (and solved) now since we just merged this PR.
#2333

@beguene beguene closed this Apr 28, 2022
@pete-watters pete-watters deleted the chore/wallet-sdk-3-4-0 branch February 14, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

+1 more reviewer

@fbwoolf fbwoolf fbwoolf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to latest @stacks/wallet-sdk Address changes to stacks.js packages

6 participants

@beguene @markmhendrickson @pradel @kyranjamie @fbwoolf