feat: sip30 stx call contract #6060
Open
+4,343
−5,878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
force-pushed
the
feat/sip30-stx-call-contract
branch
from
cfbdac1 to
776025f
Compare
fbwoolf
force-pushed
the
feat/sip30-stx-call-contract
branch
5 times, most recently
from
d96b11b to
c8db26a
Compare
fbwoolf
commented
Feb 5, 2025
fbwoolf
commented
Feb 5, 2025
| result: { | ||
| txid: '', // Broadcast transaction? | ||
| transaction: signedTransaction.serialize(), | ||
| } as any, // Fix this |
There was a problem hiding this comment.
Trying to figure out why there is a type error here on txid.
There was a problem hiding this comment.
Speaking with Jannik, by this helper method should broadcast. If apps want a tx that isn't broadcast, they should use stx_signTransaction
fbwoolf
force-pushed
the
feat/sip30-stx-call-contract
branch
2 times, most recently
from
2905ef5 to
4db5dc9
Compare
kyranjamie
reviewed
Feb 6, 2025
| export function getStxDefaultMessageParamsToTransactionRequest(params: RpcParameter) { | ||
| if (isUndefined(params)) return; | ||
|
|
||
| const transactionRequest = {} as any; |
There was a problem hiding this comment.
Can this be a Partial<ActualType>?
kyranjamie
reviewed
Feb 6, 2025
There was a problem hiding this comment.
Great work @fbwoolf—think we need to add the broadcast flow too though
fbwoolf
force-pushed
the
feat/sip30-stx-call-contract
branch
from
4db5dc9 to
cc94ead
Compare
kyranjamie
approved these changes
Feb 7, 2025
Comment on lines
+103
to
+105
| if (isCancelTransaction) return toast.success('Transaction cancelled successfully'); | ||
| if (isIncreaseFeeTransaction) return toast.success('Fee increased successfully'); | ||
| return; |
There was a problem hiding this comment.
Not necessary to refactor now, but ideally these actions would be passed in to the hook
There was a problem hiding this comment.
Yep, agree, this hook is hard to work with atm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SIP-30
stx_callContract.